Solution #1552
Open
Solution #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VolodymyrKirichenko
suggested changes
Dec 23, 2024
src/App.tsx
Outdated
Comment on lines
34
to
42
| (async () => { | ||
| try { | ||
| const data = await todoService.getTodos(); | ||
|
|
||
| setTodos(data); | ||
| } catch (err) { | ||
| setErrorMessage(Errors.UnableToLoad); | ||
| } | ||
| })(); |
There was a problem hiding this comment.
Looks better, what do u think?
Suggested change
| (async () => { | |
| try { | |
| const data = await todoService.getTodos(); | |
| setTodos(data); | |
| } catch (err) { | |
| setErrorMessage(Errors.UnableToLoad); | |
| } | |
| })(); | |
| const getAllTodos = async () => { | |
| try { | |
| const data = await todoService.getTodos(); | |
| setTodos(data); | |
| } catch (err) { | |
| setErrorMessage(Errors.UnableToLoad); | |
| } | |
| } | |
| getAllTodos(); |
src/App.tsx
Outdated
Comment on lines
45
to
113
| const onAddTodo = async (todoTitle: string) => { | ||
| setTempTodo({ | ||
| id: 0, | ||
| title: todoTitle, | ||
| completed: false, | ||
| userId: todoService.USER_ID, | ||
| }); | ||
| try { | ||
| const newTodo = await todoService.addTodo({ | ||
| title: todoTitle, | ||
| completed: false, | ||
| }); | ||
|
|
||
| setTodos(prev => [...prev, newTodo]); | ||
| } catch (err) { | ||
| setErrorMessage(Errors.UnableToAdd); | ||
| inputAddRef?.current?.focus(); | ||
| throw err; | ||
| } finally { | ||
| setTempTodo(null); | ||
| } | ||
| }; | ||
|
|
||
| const onRemoveTodo = async (todoId: number) => { | ||
| setLoadingTodoIds(prev => [...prev, todoId]); | ||
| try { | ||
| await todoService.deleteTodo(todoId); | ||
|
|
||
| setTodos(prev => prev.filter(todo => todo.id !== todoId)); | ||
| } catch (err) { | ||
| setErrorMessage(Errors.UnableToDelete); | ||
| inputAddRef?.current?.focus(); | ||
| throw err; | ||
| } finally { | ||
| setLoadingTodoIds(prev => prev.filter(id => id !== todoId)); | ||
| } | ||
| }; | ||
|
|
||
| const onUpdateTodo = async (todoToUpdate: Todo) => { | ||
| setLoadingTodoIds(prev => [...prev, todoToUpdate.id]); | ||
| try { | ||
| const updatedTodo = await todoService.updateTodo(todoToUpdate); | ||
|
|
||
| setTodos(prev => | ||
| prev.map(todo => (todo.id === updatedTodo.id ? updatedTodo : todo)), | ||
| ); | ||
| } catch (err) { | ||
| setErrorMessage(Errors.UnableToUpdate); | ||
| throw err; | ||
| } finally { | ||
| setLoadingTodoIds(prev => prev.filter(id => id !== todoToUpdate.id)); | ||
| } | ||
| }; | ||
|
|
||
| const onToggleAll = async () => { | ||
| if (todosActiveNumber > 0) { | ||
| todos | ||
| .filter(todo => !todo.completed) | ||
| .forEach(item => onUpdateTodo({ ...item, completed: true })); | ||
| } else { | ||
| todos.forEach(todo => onUpdateTodo({ ...todo, completed: false })); | ||
| } | ||
| }; | ||
|
|
||
| const onClearCompleted = async () => { | ||
| const completedTodo = todos.filter(todo => todo.completed); | ||
|
|
||
| completedTodo.forEach(todo => onRemoveTodo(todo.id)); | ||
| }; |
There was a problem hiding this comment.
do we need useCallback for these cases?
src/App.tsx
Outdated
Comment on lines
115
to
124
| const filteredTodos = todos.filter(todo => { | ||
| switch (filteredField) { | ||
| case FilterType.Active: | ||
| return !todo.completed; | ||
| case FilterType.Completed: | ||
| return todo.completed; | ||
| default: | ||
| return todos; | ||
| } | ||
| }); |
There was a problem hiding this comment.
- move this function to separate component and use
useMemofor variable - or just use useMemo
1 is better option
src/App.tsx
Outdated
Comment on lines
145
to
164
| {(todos.length > 0 || tempTodo) && ( | ||
| <> | ||
| <TodoList | ||
| todos={filteredTodos} | ||
| onRemoveTodo={onRemoveTodo} | ||
| onUpdateTodo={onUpdateTodo} | ||
| loadingTodoIds={loadingTodoIds} | ||
| tempTodo={tempTodo} | ||
| /> | ||
| <Footer | ||
| todos={todos} | ||
| filteredField={filteredField} | ||
| setFilteredField={setFilteredField} | ||
| activeTodo={todosActiveNumber} | ||
| onClearCompleted={onClearCompleted} | ||
| /> | ||
| </> | ||
| )} | ||
| </div> | ||
| <ErrorNotification |
There was a problem hiding this comment.
- use
!!to convert value to boolean type - don't forget about indents
Suggested change
| {(todos.length > 0 || tempTodo) && ( | |
| <> | |
| <TodoList | |
| todos={filteredTodos} | |
| onRemoveTodo={onRemoveTodo} | |
| onUpdateTodo={onUpdateTodo} | |
| loadingTodoIds={loadingTodoIds} | |
| tempTodo={tempTodo} | |
| /> | |
| <Footer | |
| todos={todos} | |
| filteredField={filteredField} | |
| setFilteredField={setFilteredField} | |
| activeTodo={todosActiveNumber} | |
| onClearCompleted={onClearCompleted} | |
| /> | |
| </> | |
| )} | |
| </div> | |
| <ErrorNotification | |
| {(!!todos.length || tempTodo) && ( | |
| <> | |
| <TodoList | |
| todos={filteredTodos} | |
| onRemoveTodo={onRemoveTodo} | |
| onUpdateTodo={onUpdateTodo} | |
| loadingTodoIds={loadingTodoIds} | |
| tempTodo={tempTodo} | |
| /> | |
| <Footer | |
| todos={todos} | |
| filteredField={filteredField} | |
| setFilteredField={setFilteredField} | |
| activeTodo={todosActiveNumber} | |
| onClearCompleted={onClearCompleted} | |
| /> | |
| </> | |
| )} | |
| </div> | |
| <ErrorNotification |
Comment on lines
+42
to
+50
| useEffect(() => { | ||
| inputRef?.current?.focus(); | ||
| }, [todosLength, inputRef]); | ||
|
|
||
| useEffect(() => { | ||
| if (!isInputDisabled) { | ||
| inputRef?.current?.focus(); | ||
| } | ||
| }, [isInputDisabled, inputRef]); |
There was a problem hiding this comment.
looks strange
Suggested change
| useEffect(() => { | |
| inputRef?.current?.focus(); | |
| }, [todosLength, inputRef]); | |
| useEffect(() => { | |
| if (!isInputDisabled) { | |
| inputRef?.current?.focus(); | |
| } | |
| }, [isInputDisabled, inputRef]); | |
| useEffect(() => { | |
| inputRef?.current?.focus(); | |
| }, [todosLength, inputRef]); | |
| useEffect(() => { | |
| if (!isInputDisabled) { | |
| inputRef?.current?.focus(); | |
| } | |
| }, [isInputDisabled, inputRef]); |
src/components/Header/Header.tsx
Outdated
|
|
||
| return ( | ||
| <header className="todoapp__header"> | ||
| {todosLength !== 0 && ( |
There was a problem hiding this comment.
use this syntax for all the cases(more readable)
Suggested change
| {todosLength !== 0 && ( | |
| {!!todosLength && ( |
src/types/rest.tsx
Outdated
Comment on lines
1
to
28
| // const updateTodo = (itemId, updatedTitle) => { | ||
| // const unmodifiedTodo = todos.find(todo => todo.id === itemId); | ||
|
|
||
| // if (!unmodifiedTodo) { | ||
| // endChaning(itemId); | ||
|
|
||
| // return; | ||
| // } | ||
|
|
||
| // if (updatedTitle === unmodifiedTodo.title) { | ||
| // return; | ||
| // } | ||
|
|
||
| // const updatedTodo = { | ||
| // ...unmodifiedTodo, | ||
| // title: updatedTitle !== null ? updatedTitle.trim() : unmodifiedTodo.title, | ||
| // completed: | ||
| // updatedTitle === null | ||
| // ? !unmodifiedTodo.completed | ||
| // : unmodifiedTodo.completed, | ||
| // }; | ||
|
|
||
| // if (updatedTitle !== null && updatedTodo.title === '') { | ||
| // return deleteTodo(itemId); | ||
| // } | ||
|
|
||
| // setTodos(prev => | ||
| // prev.map(todo => (todo.id === itemId ? updatedTodo : todo)), |
There was a problem hiding this comment.
remove unnecessary comments from ur project
| @@ -0,0 +1,46 @@ | |||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | |||
| const BASE_URL = 'https://mate.academy/students-api'; | |||
There was a problem hiding this comment.
move all the CONSTANTS to separate directory - constants
If I do, the tests fail Co-authored-by: VolodymyrKirichenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK